[6.4] Fix RegistrationOptions encoding to correctly merge objects#56
Merged
rintaro merged 1 commit intoMay 27, 2026
Merged
Conversation
The two members of the different `RegistrationOptions` should be encoded into a single object which contains the members of each of the two members.
Steffeeen
requested review from
ahoppen,
hamishknight,
owenv and
rintaro
as code owners
Member
|
Thank you! Could you write a nomination note using this template as described here? |
hamishknight
approved these changes
May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RegistrationOptionsthat was previously introduced. The correct behavior is to merge the two objects into one instead of having two fields, each containing one of the objects.RegistrationOptions, used when sending theclient/registerCapabilityrequestclient/registerCapabilityrequest